rezozero / commonmark-ext-footnotes

Footnotes CommonMark extension
3 stars 2 forks source link

Add aria attributes and adjust back-ref convention #5

Closed nonoesp closed 4 years ago

nonoesp commented 4 years ago

Hi, @ambroisemaupate!

This pull request adds aria accessibility role attribute to the footnotes div and footnote back-refs and changes the naming convention of refs and ids from using dashes to colons. A final step to comply with michelf/php-markdown's conventions.

ambroisemaupate commented 4 years ago

Hello @nonoesp

Thank you so much for your pull request. Hope you’re safe. I’ll try to find a moment to review it but that seems already good.

ambroisemaupate commented 4 years ago

Thanks @nonoesp!

nonoesp commented 4 years ago

Hope you're safe as well. Thanks so much for the review and woot! for releasing 1.0.0. 🥳