search

rezzza / BitterBundle

Implements a powerful analytics Symfony Bundle based on Bitter library using Redis bitmaps
http://bitter.free-agent.fr
MIT License
17 stars 5 forks source link

Suggest snc/redis-bundle on composer.json #2

Closed stephpy closed 11 years ago

stephpy commented 11 years ago

An other thing,

Why having snc_redis client by default if user has not snc/redis-bundle ? (it's only suggested and it has to be).

I guess we should show an example of usage for snc/redis-bundle but not provide a default value on redis_client, any thought ?

jeremyFreeAgent commented 11 years ago

I forgot to set snc/redis-bundle in require !

But if it's in suggest, yes the config default must not be snc.

Since snc/redis-bundle is the best one, I think we should use it in require.

stephpy commented 11 years ago

IMHO we should not. If user want to use his provider, he'll have to install snc_redis ? why ?

We could add a section on documentation to explain usage with snc/redis-bundle.

jeremyFreeAgent commented 11 years ago

Ok for me.

shouze commented 11 years ago

:+1: as snc/redis suggested

shouze commented 11 years ago

:octocat: rules them all

stephpy commented 11 years ago

I'll do it today, wait for commit before merge.

jeremyFreeAgent commented 11 years ago

Sure. Squash them.

stephpy commented 11 years ago

Squashed. I added a branch-alias. And add not blank validation on Configuration.

jeremyFreeAgent commented 11 years ago

Ok I merge it ! Thanks !