rfaulkner / wikipedia_user_metrics

Wikimedia Foundation E3 Team Analysis Code
Other
9 stars 5 forks source link

Metrics. Use settatr to build attributes for metrics classes from _param_types #18

Closed rfaulkner closed 11 years ago

rfaulkner commented 11 years ago

Currently:

def __init__(self, **kwargs):

    # Add params from base class
    self.append_params(um.UserMetric)
    self.apply_default_kwargs(kwargs,'init')

    self._date_start_ = um.UserMetric._get_timestamp(kwargs['date_start'])
    um.UserMetric.__init__(self, **kwargs)

Update:

def __init__(self, **kwargs):

    # Add params from base class
    self.append_params(um.UserMetric)
    self.apply_default_kwargs(kwargs,'init')

    for att in _param_types['init']:
           setattr(self,att[0],att[2])

    um.UserMetric.__init__(self, **kwargs)
rfaulkner commented 11 years ago

implemented. https://github.com/rfaulkner/E3_analysis/commit/cd3fff950846c050177a7119e2c117310a59e7e0