rfaulkner / wikipedia_user_metrics

Wikimedia Foundation E3 Team Analysis Code
Other
9 stars 5 forks source link

API. Single user end point REGEX cannibalizes some cohort ID patterns #46

Closed rfaulkner closed 11 years ago

rfaulkner commented 11 years ago

We should clearly separate requests that take single users or cohorts as input via separate endpoints. Right now a parameter matching MW_UID_REGEX is always interpreted as a user_id, meaning that calling a cohort by tag_id, e.g. /cohorts/1 (which allowed among other things boolean tag combination) is broken.

rfaulkner commented 11 years ago

fixed. User requests are now specified by a query parameter. https://github.com/rfaulkner/E3_analysis/commit/d4d08a7cd87dc60082d15c7f23e1020be335e8c6