search

rfcs / crypto-conditions

Composable cryptographic conditionals (signatures, hashes)
https://tools.ietf.org/html/draft-thomas-crypto-conditions-03
22 stars 12 forks source link

test vectors: additional use cases to test for #14

Open sbellem opened 7 years ago

sbellem commented 7 years ago

A condition can be validated for its correctness, so this PR proposes to add this test to the existing list of things to test for the test vectors.

Since a Condition object may be created from two different sources: DER encoded binary and URI, checking whether the parsed Condition validates to TRUE can be done for both the binary and URI, hence two new things to test for.

stevenroose commented 7 years ago

Now that you are at it, could you clarify that validation should be done with the given message? It's not clear from the current working. (In the existing test cases.)

stevenroose commented 7 years ago

Also, the two cases you added don't specify what fulfillment to validate for the two conditions you generate. The binary one or the json one.

stevenroose commented 7 years ago

Also, another issue probably. It's unclear whether the message is encoded as UTF8, hex or base64.

sbellem commented 6 years ago

@stevenroose @sappenin sorry for the massive delay, will try to address the points asap.