incorrect uri format - Githubissues

rfcs / crypto-conditions

Composable cryptographic conditionals (signatures, hashes)

https://tools.ietf.org/html/draft-thomas-crypto-conditions-03

22 stars 12 forks source link

incorrect uri format #2

Closed andrew-g-za closed 7 years ago

andrew-g-za commented 7 years ago

Hi,

I've created a PR to

fix the uri format of the test template
add a note on where to find the ffasn1dump tool

Please take a look.

adrianhopebailie commented 7 years ago

This change is required but actually still not 100% correct. Based on the defintion of the ni: URI format in RFC6920 there should be 3 slashes /.

3.  Named Information (ni) URI Format

   A Named Information (ni) URI consists of the following nine
   components:

   Scheme Name:  The scheme name is 'ni'.

   Colon and Slashes:  The literal "://"

   Authority:  The optional authority component ...

   One slash:  The literal "/"

   ....

andrew-g-za commented 7 years ago

Thanks Adrian,

updated with 6c32091.

justmoon commented 7 years ago

Please rebase to squash the two commit into one. And please follow our commit message guidelines, i.e. something like fix: ni: URIs should start with three slashes