rfcx / rfcx-api

Core, Media/Assets and MQTT APIs
https://api.rfcx.org/docs/
Apache License 2.0
0 stars 0 forks source link

Update site name from Arbimon make timezone to default UTC #584

Closed Tooseriuz closed 5 months ago

Tooseriuz commented 5 months ago

Update site name from Arbimon make site timezone back to UTC

How to reproduce

  1. go to Arbimon
  2. select 1 site
  3. edit only its name
  4. save
  5. check timezone

the problem is the function that receiving updated site data and existing site data. when updated data is only name, it thinks that we update name and site lat/lon null then set timezone to default UTC.

carlybatist commented 5 months ago

@Tooseriuz any update on this? The user continued to add more sites and they had the same problem with the incorrect time zone being added. All sites need to be fixed so that they are UTC-8. Thanks!

Screenshot 2024-04-16 at 11 59 50 AM

Tooseriuz commented 5 months ago

@carlybatist , There is a workaround that you can edit latitude or longitude with the very small number changed for the example site P08 you can change latitude to 4.635 save it and then timezone should be fixed. now you can change it back to 4.636

The fix, we are working on it and now it is in the review process. I will let you know when it is released to the production

carlybatist commented 5 months ago

@carlybatist , There is a workaround that you can edit latitude or longitude with the very small number changed for the example site P08 you can change latitude to 4.635 save it and then timezone should be fixed. now you can change it back to 4.636

The fix, we are working on it and now it is in the review process. I will let you know when it is released to the production

Ok thank you so much!

carlybatist commented 5 months ago

@Tooseriuz (and cc @koonchaya ) but even if you change the site timezone using this workaround, all the recordings for that site will have the wrong timestamp still. The timezone is assigned to the recordings at time of upload, so if the timezone was wrong, the file timestamp will be wrong too.

You can see here - recordings in site p08 are incorrect, recordings in pl4 are correct (UTC-8 timezone) Screenshot 2024-04-16 at 1 07 01 PM Screenshot 2024-04-16 at 1 08 10 PM

Tooseriuz commented 5 months ago

@carlybatist , could you ask users to stop uploading before we release the fix ? or ask them to check if the timezone is correct ? we will release it asap

carlybatist commented 5 months ago

@Tooseriuz yes we told them to stop now, but apparently they were uploading new sites over the weekend before we knew about the extent of this. sorry about that...