Calling `GET /detections/summary` before `GET /detections` will make the latter call not return all requested attributes. - Githubissues

rfcx / rfcx-api

Core, Media/Assets and MQTT APIs

https://api.rfcx.org/docs/

Apache License 2.0

0 stars 0 forks source link

Calling `GET /detections/summary` before `GET /detections` will make the latter call not return all requested attributes. #601

Closed grindarius closed 4 months ago

grindarius commented 4 months ago

✅ DoD

[x] Resolves #600
[ ] API docs updated na
[x] Release notes updated
[ ] Deployment notes updated na
[x] Unit or integration tests added
[ ] DB migrations tested na

(use na when API docs (Release notes, etc) do not need to be updated)

📝 Summary

Refactor the part in GET /detections/summary bll that modifies the opts.include to make it do a map and return new array instead of modifying one. Because of the in-place modification it makes the other API call affected by it.
Added checks for when GET /detections/summary is being called before GET /detections. All attributes are returned as requested.

📸 Examples

Put screenshots or response/request examples here!

🛑 Problems

Write any discovered & unresolved problems (link to created Jira issues)

💡 More ideas

Write any more ideas you have

grindarius commented 4 months ago

I cannot reproduce the errors locally. I will try again later tomorrow

grindarius commented 4 months ago

No way removing the test is the way to go. The run passed without any problems. Guess it's because the difference between each commonSetup function.