Fix review detection can update review status to multiple detections of same project

rfcx / rfcx-api

Core, Media/Assets and MQTT APIs

https://api.rfcx.org/docs/

Apache License 2.0

0 stars 0 forks source link

Fix review detection can update review status to multiple detections of same project #618

Closed grindarius closed 5 months ago

grindarius commented 5 months ago

✅ DoD

[x] Resolves #602
[ ] API docs updated na
[x] Release notes updated
[ ] Deployment notes updated na
[x] Unit or integration tests added
[ ] DB migrations tested na

(use na when API docs (Release notes, etc) do not need to be updated)

📝 Summary

Make call to update of detection dao accept detectionId as one of the where clause parameters to update to uniquely update the detection status. We have a problem where streamId and start is not unique enough in some cases where one stream segment can have multiple classifications on it.
Remove request log added in #615 (GDPR reasons, also the investigation is over (for now)).

📸 Examples

Put screenshots or response/request examples here!

🛑 Problems

Write any discovered & unresolved problems (link to created Jira issues)

💡 More ideas

Write any more ideas you have

antonyharfield commented 5 months ago

Does it still match the description after this change?

/**
 * @swagger
 *
 * /streams/{streamId}/detections/{start}/review:
 *   post:
 *     summary: Review a detection
 *     description: Creates or updates reviews for any detections matching stream and start

grindarius commented 5 months ago

Does it still match the description after this change?

/**
 * @swagger
 *
 * /streams/{streamId}/detections/{start}/review:
 *   post:
 *     summary: Review a detection
 *     description: Creates or updates reviews for any detections matching stream and start

I will change the description to "Creates or updates a review for a detection matching stream, start, classification value, classifier, and classifier job" because the where clause to find the detections are using start, stream_id, classification_value, classifier_id, and classifier_job_id,