search

rfennell / ReleaseNotesAction

This Action uses the GitHub API and a Handlebars based template to generate a release notes file. This file can be used in a variety of ways, such as being attached to a release, or uploaded to an external store such as a WIKI
MIT License
12 stars 2 forks source link

Have to commit the node_module folder #81

Open rfennell opened 3 years ago

rfennell commented 3 years ago

Unfortunately, there is an issue with Handlebars that stops it from being used with ncc.

Until this is addressed the node-modules folder needs to be committed to the repo containing the production dependencies for use at runtime.

There error is 

Processing template
Error: Invalid left-hand side in assignment
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Run /./

This has been logged with Handlebars as #375

rfennell commented 3 years ago

A test was done using #82 but the problem still exists

rfennell commented 3 years ago

Re tested with "@vercel/ncc": "^0.29.0" still has the same issue

rfennell commented 2 years ago

I don't think there will be a solution to this without either replacing handlebars-helpers or forking and rebuilding, but I have raised an issue https://github.com/helpers/handlebars-helpers/issues/375