search

rfhs / rfctf-container

scripts that go in the rfctf container
BSD 2-Clause "Simplified" License
17 stars 9 forks source link

Add curl to kali and parrot. #6

Closed UsakoSenpai closed 3 years ago

ZeroChaos- commented 3 years ago

is it only missing from kali?

On Thu, Aug 12, 2021 at 2:14 AM Usako @.***> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/rfhs/rfctf-container/pull/6 Commit Summary

  • Add curl to kali client.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rfhs/rfctf-container/pull/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMX56L5FHHPX3UBI4YUI6DT4NRC7ANCNFSM5CAKG3WA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

UsakoSenpai commented 3 years ago

Uncertain, I noticed it on kali during the ctf. I was going to build the containers and check the other ones, but haven't yet. If you want to leave this open until then, I'll make an update (if needed) or I can make a PR later with changes (if any needed). Up to you. I'll try to look tonight, weekend at latest.

ZeroChaos- commented 3 years ago

you don't have to build the containers to test, just "docker exec -it rfhs/parrot /bin/bash" for example

UsakoSenpai commented 3 years ago

lol.. I know how containers work.. I just didn't know if they were available to pull (hadn't seen in a registry yet), but also I'd prefer to build just to make sure the Dockerfile changes work (although I did just pop this one in without doing so) 😅

UsakoSenpai commented 3 years ago

Sweet, I do see now they're all up on dockerhub. cool cool cool https://hub.docker.com/search?q=rfhs&type=image

ZeroChaos- commented 3 years ago

lol.. I know how containers work.. I just didn't know if they were available to pull (hadn't seen in a registry yet), but also I'd prefer to build just to make sure the Dockerfile changes work (although I did just pop this one in without doing so)

the public build scripts and the public startup scripts (both in this repo) kinda provide this hint ;-)

UsakoSenpai commented 3 years ago

Yeah, but you have to have looked at them to see that. lol I knew I needed to add curl and wanted to put that in before I forgot about it. So, I really only looked at the Dockerfile in that instant.

I also had a couple other tools I installed, but uncertain they should be preinstalled. At least one had an existing alternative that I just didn't notice during the CTF, but saw in the Dockerfile. hostapd The other was isc-dhcp-client, which I couldn't find an alt for, but might just not know what the alt is. Not being certain about that, I left both out of the PR.

ZeroChaos- commented 3 years ago

hostapd-wpe isn't sufficient for some reason?

UsakoSenpai commented 3 years ago

At least one had an existing alternative that I just didn't notice during the CTF, but saw in the Dockerfile.

I'm assuming it is, which is why I didn't add hostapd in the PR. Probably, I somehow missed it / didn't know -wpe was a thing. owo; Looking at the project for that, I see now why it's preferred for this. :D

UsakoSenpai commented 3 years ago

@ZeroChaos- Added to parrot. The other two already have it.

ZeroChaos- commented 3 years ago

Thanks!