search

rfink / angular-chrono

A timer directive for angularjs
MIT License
8 stars 6 forks source link

.min does not quite work #3

Closed romuloctba closed 9 years ago

romuloctba commented 10 years ago

Hi guys First thanks for this, i'm using it already :)

Secondly, please note that i couldn't manage it to work by including angular-chrono.min.js but it worked just fine when I took the 'min' off the file name. (Used not minified version)

Thats it, maybe just some trouble with dependency injection... If i can i shall fix this and send you a commit, but unfortunally i cant promisse to do this anytime soon :(

Thanks again

rfink commented 10 years ago

Thanks for the report. I'll look into this very soon, and will let you know when it's resolved.

rfink commented 9 years ago

This was due to an issue with the directive injectables, I've corrected and tested. Thanks for bringing this to my attention. Hope you continue to enjoy it.

romuloctba commented 9 years ago

Thanks, i'm into it... Just made some logic to 'resume where stopped' and i'm integrating with some localStorage Db.

I hope i'll be pull requesting here soon

2014-11-18 11:30 GMT-02:00 rfink notifications@github.com:

Closed #3 https://github.com/rfink/angular-chrono/issues/3.

— Reply to this email directly or view it on GitHub https://github.com/rfink/angular-chrono/issues/3#event-194847303.

rfink commented 9 years ago

Interesting. I'm looking forward to seeing that.