search

rfjakob / gocryptfs

Encrypted overlay filesystem written in Go
https://nuetzlich.net/gocryptfs/
MIT License
3.54k stars 252 forks source link

xfstests generic/391 spurious failure #244

Closed rfjakob closed 6 years ago

rfjakob commented 6 years ago

Fails with

generic/391  - output mismatch (see /home/jakob.donotbackup/code/fuse-xfstests/results//generic/391.out.bad)
    --- tests/generic/391.out   2018-01-20 14:29:39.105452050 +0100
    +++ /home/jakob.donotbackup/code/fuse-xfstests/results//generic/391.out.bad 2018-06-12 21:09:21.912486666 +0200
    @@ -1,2 +1,3 @@
     QA output created by 391
    +open: Invalid argument
     Silence is golden
    ...
    (Run 'diff -u tests/generic/391.out /home/jakob.donotbackup/code/fuse-xfstests/results//generic/391.out.bad'  to see the entire diff)

Apparently it tries to use O_DIRECT without checking for FS support first.

rfjakob commented 6 years ago

Fix has been accepted into xfstests: https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?id=072ff808cf9cb2871236828aaab028c725d4a657

rfjakob commented 6 years ago

Fixed by rebasing to latest xfstests, https://github.com/rfjakob/fuse-xfstests/tree/gocryptfs-2018-06-20