rfmoz / grafana-dashboards

Grafana dashboards
Apache License 2.0
1.17k stars 445 forks source link

Support meaningful instance labels #57

Closed candlerb closed 4 years ago

candlerb commented 4 years ago

When using meaningful instance labels there is only a name, and no port number, in the instance label. Unfortunately, the existing node_exporter dashboard does not work without a port.

I suggest using the instance label directly.

Also, given that job and node are not multi-select, these can use = rather than =~ for matching (more efficient, less likely to trip up on regexp metacharacters)

I've made these changes in 12486 which is a direct fork of 1860.

rfrail3 commented 4 years ago

Thanks for update the dashboard with the work done, it helps.