Feature request: add random forest imputation

rformassspectrometry / MsCoreUtils

Core Utils for Mass Spectrometry Data

https://rformassspectrometry.github.io/MsCoreUtils/

16 stars 11 forks source link

Feature request: add random forest imputation #82

Closed cvanderaa closed 2 years ago

cvanderaa commented 3 years ago

Hi, I've received feedback from a user that is using scp which depends on QFeatures. The user asked whether we could also implement a random forest imputation. He suggested the missForest package. Taking advantage of the wrapper function that already exists in imp4p (the function is called impute.RF) might facilitate its integration in the rformassspectrometry project. I thought that this could fit in the MsCoreUtils package.

jorainer commented 3 years ago

My only concern is that we should try to keep the dependencies of the MsCoreUtils package as small as possible - also to reduce package loading time.

lgatto commented 3 years ago

Yes, I agree that we should avoid too many dependencies.

We would have these as suggests (which is already the case for many dependencies related to imputation and normalisation). Would that be ok, not only for now, but as a general solution for future situations.
Otherwise, we could externalise some of the MsCoreUtils function, say all the imputation ones, to a dedicated package. Not sure this would be the best option at this stage though.

jorainer commented 3 years ago

Suggests with requireNamespace is fine for me

cvanderaa commented 2 years ago

This issue is solved by PR #98