rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra
https://rformassspectrometry.github.io/Spectra/
37 stars 25 forks source link

Check that we're not overestimating similarity in compareSpectra #117

Open jorainer opened 4 years ago

jorainer commented 4 years ago

This is based on a comment from @mvinaixa: we should make sure we're not calculating the similarity score only on the peaks that match between the compared spectra, but consider also the non-matching peaks because otherwise we overestimate the similarity. I'll have to dig into the functions to see if this is the case (I guess it is - just to be sure).