rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra
https://rformassspectrometry.github.io/Spectra/
37 stars 25 forks source link

Filtering spectra by m/z #133

Closed jorainer closed 3 years ago

jorainer commented 4 years ago

There are two different use cases of filtering a spectrum by m/z:

We could now either: 1) implement two separate filter methods filterMzRange for the first and filterMz for the latter use case. 2) implement a single filterMz with a parameter range = TRUE to switch between range- or match-based filtering.

@sgibb @lgatto any comments, ideas?

lgatto commented 4 years ago

I prefer two separate functions rather than a parameter and would suggest

jorainer commented 4 years ago

Fine for me. Thanks @lgatto