fix: ensure backend is changed in Spectra,character constructor

rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra

34 stars 24 forks source link

Closed jorainer closed 3 years ago

jorainer commented 3 years ago

Fix that the backend is changed even if the backend passed with source extends the backend specified with backend (issue #146).

lgatto commented 3 years ago

Looks good, but could you point me to the issue or example that triggered this change. I can only vaguely remember it.

jorainer commented 3 years ago

Sure, sorry @lgatto , I linked a wrong issue. The correct one is #143 .

lgatto commented 3 years ago

Merged now. Olly, could you install from Github with

BiocManager::install("RforMassSpectrometry/Spectra")

and confirm that it now works.

lgatto commented 3 years ago

@jorainer - I tried to push to Bionconductor, but don't have access. Will email Nitesh and cc you.

lgatto commented 3 years ago

On Bioc (devel) too, now.