fix: replacing spectraData on Spectra does not remove m/z

rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra

https://rformassspectrometry.github.io/Spectra/

34 stars 24 forks source link

fix: replacing spectraData on Spectra does not remove m/z #147

Closed jorainer closed 3 years ago

jorainer commented 3 years ago

Avoid removing m/z and intensity values when calling spectraData<-,Spectra (issue #146).

jorainer commented 3 years ago

An additional change in this PR is that I moved most of the filter* functions from MsBackendDataFrame to MsBackend hence avoiding the need to re-implement these methods for all new backends.

jorainer commented 3 years ago

@lgatto , did you already push to Bioconductor?

lgatto commented 3 years ago

~Was about to, but it looks like you have just done it.~ Done.

jorainer commented 3 years ago

But there are some strange things - like the github and bioconductor masters are not in sync - please see PR #148 (please don't merge that one!).