rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra
https://rformassspectrometry.github.io/Spectra/
34 stars 24 forks source link

feat: new joinSpectraData() function #160

Closed lgatto closed 3 years ago

lgatto commented 3 years ago

This PR addressed #149

lgatto commented 3 years ago
lgatto commented 3 years ago

I also fixed a missing export statement.

@jorainer - feel free to merge if you are happy with the PR.

jorainer commented 3 years ago

And pushed to BioC

lgatto commented 3 years ago

There is an issue with checks, which I didn't have locally. I'm investigating.

jorainer commented 3 years ago

No worries - it's because the new docker image with Bioconductor 3.13 is not yet working properly (I think the DelayedArray package is not available yet).

jorainer commented 3 years ago

Actually, seems it's more the msdata and the vdiffr packages. Install/download of msdata fails due to a corrupt download also for me:

> BiocManager::install("msdata")
Bioconductor version 3.13 (BiocManager 1.30.10), R Under development (unstable)
  (2020-10-24 r79367)
Installing package(s) 'msdata'
trying URL 'https://bioconductor.org/packages/3.13/data/experiment/src/contrib/msdata_0.31.0.tar.gz'
Content type 'application/x-gzip' length 446179202 bytes (425.5 MB)
===========================
downloaded 237.2 MB

Error in download.file(url, destfile, method, mode = "wb", ...) : 
  download from 'https://bioconductor.org/packages/3.13/data/experiment/src/contrib/msdata_0.31.0.tar.gz' failed
In addition: Warning messages:
1: In download.file(url, destfile, method, mode = "wb", ...) :
  downloaded length 248742946 != reported length 446179202
2: In download.file(url, destfile, method, mode = "wb", ...) :
  URL 'https://bioconductor.org/packages/3.13/data/experiment/src/contrib/msdata_0.31.0.tar.gz': Timeout of 60 seconds was reached
Warning in download.packages(pkgs, destdir = tmpd, available = available,  :
  download of package ‘msdata’ failed
lgatto commented 3 years ago

This seems a temporary glitch - I was able to re-install that same version of msdata locally:

> packageVersion("msdata")
[1] ‘0.31.0’
> BiocManager::install("msdata")
Bioconductor version 3.13 (BiocManager 1.30.10), R Under development (unstable)
  (2020-04-28 r78328)
Installing package(s) 'msdata'
trying URL 'https://bioconductor.org/packages/3.13/data/experiment/src/contrib/msdata_0.31.0.tar.gz'
Content type 'application/x-gzip' length 446179202 bytes (425.5 MB)
==================================================
downloaded 425.5 MB

* installing *source* package ‘msdata’ ...
** using staged installation
** R
** data
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (msdata)

The downloaded source packages are in
    ‘/tmp/RtmpzHuMM8/downloaded_packages’
Installation path not writeable, unable to update packages: codetools,
  KernSmooth
> packageVersion("msdata")
[1] ‘0.31.0’
jorainer commented 3 years ago

I get the same error again and again (although the size of the downloaded file differs). I'm wondering if this might have to do with the current developmental version of R (i.e. 4.1).