search

rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra
https://rformassspectrometry.github.io/Spectra/
34 stars 24 forks source link

pickPeaks missing ... #168

Closed ococrook closed 3 years ago

ococrook commented 3 years ago

I think the method for pickPeaks is missing a ... argument

I would expect span = 0.2 to be passed to the function noise

peaksMethod = "SuperSmoother"
snr <- 2
object_sub <- Spectra::pickPeaks(object_sub,
                                 method = peaksMethod,
                                 halfWindowSize = halfWindowSize,
                                 snr = snr, k = 0L, descending = FALSE, threshold = 0, msLevel = 1, span = 0.2)

Error in .local(object, ...) : unused argument (span = 0.2)

jorainer commented 3 years ago

Thanks for reporting! (and sorry for the delay) - I'll look into this.

jorainer commented 3 years ago

Version 1.1.11 fixes this. Please close the issue after veryfying that it works for you.

ococrook commented 3 years ago

This works for me, thanks!