search

rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra
https://rformassspectrometry.github.io/Spectra/
37 stars 25 forks source link

Move filter functions to the backend #189

Closed jorainer closed 3 years ago

jorainer commented 3 years ago

This is related to issue https://github.com/rformassspectrometry/MsBackendMassbank/issues/28 . The point is that subsetting and filtering could/should be done on the backend side because it's actually part of the duty of the backend, i.e. manage and provide the data. I'll do some tests, but to me it seems possible to move the implementations we have at present for Spectra objects to the MsBackend as a default implementation and new backends can implement their own filter function if it makes sense (such as for SQL backends, it would make sense to do the filtering directly using SQL).

Happy to discuess @lgatto @sgibb

jorainer commented 3 years ago

Please ignore this - I should check the code first before writing an issue (and maybe also drink a coffee before doing so) - the filter functions are already in the backend...