search

rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra
https://rformassspectrometry.github.io/Spectra/
34 stars 24 forks source link

Install test suite for backend packages #224

Closed sneumann closed 2 years ago

sneumann commented 2 years ago

This is working on #186 . Spectra now includes (and installs) a directory with tests that can be called from the backends. There could (should!) be a few different profiles, checking a (minimum) set of functionality provided by the backends. The initially provided one barely tests anything yet. Yours, Steffen

jorainer commented 2 years ago

This PR looks extremely interesting, thanks @sneumann and @hechth. I would however provide an already initialized MsBackend with the be variable since not all backends will have (only) a file parameter (e.g. expecting a database connection instead or even a data frame or similar).

Another very important test suite would be a general test_valid_MsBackend test suite that takes an already initialized MsBackend variable be and then runs all methods defined in the MsBackend.R file and checks that the returned result is as expected (i.e. expected data type, length of data matches expectation etc). Question is if you are planning to add that too or if we (I) should do that?

sneumann commented 2 years ago

I think this can now be closed in favour of https://github.com/rformassspectrometry/Spectra/pull/227 ?

jorainer commented 2 years ago

It's up to you @sneumann - you're more than welcome to add additional test suites. #227 adds only test suites for accessing/setting variables.

jorainer commented 2 years ago

Closing this PR now.