search

rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra
https://rformassspectrometry.github.io/Spectra/
34 stars 24 forks source link

Combine peaks #296

Closed jorainer closed 1 year ago

jorainer commented 1 year ago

This PR adds a combinePeaks,Spectra method that (as the name says) combines peaks within each spectrum. The old combinePeaks function (used by combineSpectra) was renamed to combinePeaksData as described in #292.

lgatto commented 1 year ago

Looking here, the message says that the backend will be changed to one supporting data modification. Is this done implicitly by the .combine_spectra()?

jorainer commented 1 year ago

Looking here, the message says that the backend will be changed to one supporting data modification. Is this done implicitly by the .combine_spectra()?

yes, it's done here

lgatto commented 1 year ago

Here's the code that deals with invariant columns in QFeatures https://github.com/rformassspectrometry/QFeatures/blob/master/R/reduce.R