Closed jorainer closed 4 years ago
@sgibb, should I wait for your review or am I OK to merge?
Merging #95 into master will decrease coverage by
<.01%
. The diff coverage is95.31%
.
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 90.17% 90.17% -0.01%
==========================================
Files 16 16
Lines 1456 1455 -1
==========================================
- Hits 1313 1312 -1
Misses 143 143
Impacted Files | Coverage Δ | |
---|---|---|
R/Spectra-functions.R | 96.45% <ø> (-0.13%) |
:arrow_down: |
R/MsBackendMzR.R | 97.05% <ø> (ø) |
:arrow_up: |
R/Spectra.R | 93.05% <100%> (-0.13%) |
:arrow_down: |
R/MsBackend.R | 10.14% <100%> (+7.01%) |
:arrow_up: |
R/AllGenerics.R | 100% <100%> (ø) |
:arrow_up: |
R/MsBackendDataFrame.R | 97.86% <86.66%> (ø) |
:arrow_up: |
R/MsBackendHdf5Peaks.R | 90.28% <96.15%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ffa0911...5eaafca. Read the comment docs.
This PR (discussed in #92)
spectraData,MsBackend
method withasDataFrame,MsBackend
(andspectraData<-,MsBackend
withasDataFrame<-,MsBackend
.spectraVariables,Spectra
to not return"mz"
and"intensity"
with the result thatspectraData,Spectra
does return only aDataFrame
with spectra metadata, no m/z and intensity values.dropNaSpectraVariables
to allow application of this function to bothSpectra
andMsBackend
(the function that was in place before usedspectraData
, that now however does no longer exist forMsBackend
. I thought this function might still be useful forMsBackend
and that's why I added it as a method.