rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra
https://rformassspectrometry.github.io/Spectra/
37 stars 25 forks source link

spectraData,Spectra does not return m/z and intensity values #95

Closed jorainer closed 4 years ago

jorainer commented 4 years ago

This PR (discussed in #92)

jorainer commented 4 years ago

@sgibb, should I wait for your review or am I OK to merge?

codecov-io commented 4 years ago

Codecov Report

Merging #95 into master will decrease coverage by <.01%. The diff coverage is 95.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   90.17%   90.17%   -0.01%     
==========================================
  Files          16       16              
  Lines        1456     1455       -1     
==========================================
- Hits         1313     1312       -1     
  Misses        143      143
Impacted Files Coverage Δ
R/Spectra-functions.R 96.45% <ø> (-0.13%) :arrow_down:
R/MsBackendMzR.R 97.05% <ø> (ø) :arrow_up:
R/Spectra.R 93.05% <100%> (-0.13%) :arrow_down:
R/MsBackend.R 10.14% <100%> (+7.01%) :arrow_up:
R/AllGenerics.R 100% <100%> (ø) :arrow_up:
R/MsBackendDataFrame.R 97.86% <86.66%> (ø) :arrow_up:
R/MsBackendHdf5Peaks.R 90.28% <96.15%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffa0911...5eaafca. Read the comment docs.