search

rformassspectrometry / Spectra

Low level infrastructure to handle MS spectra
https://rformassspectrometry.github.io/Spectra/
37 stars 25 forks source link

refactor: import ndotproduct instead of dotproduct from MsCoreUtils #97

Closed jorainer closed 4 years ago

jorainer commented 4 years ago

Import ndotproduct instead of dotproduct from MsCoreUtils.

codecov-io commented 4 years ago

Codecov Report

Merging #97 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files          16       16           
  Lines        1455     1455           
=======================================
  Hits         1312     1312           
  Misses        143      143
Impacted Files Coverage Δ
R/Spectra-functions.R 96.45% <ø> (ø)
R/Spectra.R 93.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33ad5d1...90a726a. Read the comment docs.

jorainer commented 4 years ago

I'm going to boldly merging this PR without review - as it just imports the ndotproduct from MsCoreUtils instead of the dotproduct.