search

rformassspectrometry / SpectraQL

Mass Spec Query Language (MassQL) support for Spectra
https://rformassspectrometry.github.io/SpectraQL/
7 stars 2 forks source link

filter functions and OR #3

Closed andreavicini closed 2 years ago

andreavicini commented 2 years ago

Thank you very much @sgibb for the review and suggestions. As for the general question I had in mind only a query with sintax VARIABLE = (value1 OR value2) and I found only that usage in the SpectraQL Documentation but maybe @jorainer knows more

andreavicini commented 2 years ago

Ok, yes .to.numeric is not needed and everything can be done also without it. It was just to convert things when they can be converted and stop the function when they cannot by throwing an appropriate error message instead of converting each parameter and then each time check if the result of as.numeric contains any NA (and if so stop the function). Also in some cases we don't know if a NA was originated by a "NA" (which in some cases is ok) or a different character not corresponding to a number. But ok I will replace it with checks for each parameter in the filter functions.