Closed sgibb closed 6 years ago
What will be the intended use of these data? If one usecase is for users to manipulate it, I would suggest to convert it to a tibble
. I think that the data(aminoacids)
is a good way to distribute that data.
I think it would be good for MSnbase
and Pbase
to use the data from unimod
. That will require for unimod
to be in Bioconductor first.
That will require for
unimod
to be in Bioconductor first.
Just saw the Bioconductor milestone now.
IMHO there is no need to allow modification by the user. Information about chemical elements and amino acids are constants that are rarely changed. Nevertheless a data.frame
that is accessible via data(elements)
and data(aminoacids)
would be ok.
Is there any specific reason to use a tibble
. Isn't it just a data.frame
with a different constructor/different defaults, fancy printing and modified subset methods? Shouldn't we stay as base
as possible?
Shouldn't we stay as
base
as possible?
If there is a lot of manipulation to be expected and described in the vignette/manuals, then I think it's possibly worth using a tibble
and the tidyverse
. Otherwise yes, let's stick to data.frame
s - users can always convert it if they see fit.
The
unimod.xml
file provides mass information about most chemical elements and aminoacids. The unimod package is already able to parse these information intodata.frames
:How could we store these
data.frames
in the package that they could easily be used by other packages, namely. MSnbase and Pbase:environment
s in https://github.com/lgatto/MSnbase/blob/master/R/environment.R could be replaced.environment
s provides by MSnbase. Pbase could be completely independent of MSnbase (and depend on unimod instead).I could store them as
.RData
in so that they could be loaded bydata(aminoacids)
. Any other suggestions?