search

rformassspectrometry / unimod

Amino acid modifications for mass spectrometry
6 stars 0 forks source link

Functions rather than generics/methods #5

Closed lgatto closed 7 years ago

lgatto commented 7 years ago

I would suggest to simplify the code as much as possible and only use generics and methods when necessary. Currently, in AllGenerics.R, I think most generics have pretty specialised names anyway and, unless they are supposed to operate on multiple classes (currently only one is defined in the package, but more might be added), I would suggest to fall back to plain functions.

sgibb commented 7 years ago

Thanks for all your comments! I am not sure whether we need more classes. I will replace the methods by simple functions.