search

rfortherestofus / api-food-asset-map

5 stars 1 forks source link

Make sure API population legend matches data #47

Closed dgkeyes closed 3 years ago

dgkeyes commented 3 years ago

In 3883fbf9d10ae651e6b691f05f8500549b116b29 I changed the API population legend back to using colorQuantile() because I think it was too hard to see the distinctions when it used colorNumeric(). However, I'm now seeing that the data shown in the tooltips doesn't match the legend. Short video to explain.

katiejolly commented 3 years ago

Yeah, I had switched it to colorNumeric to see if it had the same issue and forgot to leave a note in the code about it. I think I'll manually bin the data and assign colors based on that.

On Mon, May 17, 2021 at 11:05 AM David Keyes @.***> wrote:

Assigned #47 https://github.com/rfortherestofus/api-food-asset-map/issues/47 to @katiejolly https://github.com/katiejolly.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/rfortherestofus/api-food-asset-map/issues/47#event-4756126816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCZ4HNF3D2RDAXU7K5U5LDTOFLGRANCNFSM45A6FFIQ .

dgkeyes commented 3 years ago

Sounds good!

katiejolly commented 3 years ago

image

katiejolly commented 3 years ago

Closing since the issue is resolved.