search

rfortherestofus / api-food-asset-map

5 stars 1 forks source link

Adjust clustering? #69

Closed dgkeyes closed 3 years ago

dgkeyes commented 3 years ago

The client wrote me this about the clustering:

General thoughts: At first it wasn’t clear why the circles were different colors so I was looking for a key but I get now that it’s just based on the number in that area - it seems kinda weird though, like as if having more is worse since it goes from green (low #) to orange (high #).

My general thought here is to add a legend that explains it. @katiejolly if you have other ideas, let me know.

katiejolly commented 3 years ago

I can look into this tonight or tomorrow!

Sent from my iPhone

On Jun 2, 2021, at 13:58, David Keyes @.***> wrote:

 The client wrote me this about the clustering:

General thoughts: At first it wasn’t clear why the circles were different colors so I was looking for a key but I get now that it’s just based on the number in that area - it seems kinda weird though, like as if having more is worse since it goes from green (low #) to orange (high #).

My general thought here is to add a legend that explains it. @katiejolly if you have other ideas, let me know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

dgkeyes commented 3 years ago

Thanks! I'm actually heading out of town for the weekend but will get back to you on Monday.

katiejolly commented 3 years ago

There are a few options I see here:

  1. Add a comment about the existing clustering to the UI

  2. Edit the clustering so it goes in the opposite order (we can set the threshold for the breaks manually). This could also include a comment about what the colors mean. See below: image

  3. Change the colors so that it's always orange, yellow, or green (changing the actual color is a little more challenging)

katiejolly commented 3 years ago

Let me know what you think is best here! All 3 are similar levels of effort, an hour or so max.

dgkeyes commented 3 years ago

Thanks! I think just using one color is the best option. I wrote this to the client:

On the clustering issue, I think the best solution here would be to remove the green/yellow/orange colors. If we make the circles all, say, green then it should be clearer that it's just showing groups of stores, and the color doesn't mean anything. Please let me know what you think and we'll go from there!

I'll let you know what they say.

dgkeyes commented 3 years ago

Ok, heard back. Let's go with removing the multiple colors. Can you please try it with just green on the clustering circles and also tell me how you do it so that I can change it if I want to do so in the future? Thanks!

katiejolly commented 3 years ago

Here's what the all green looks like! image

I'll add a note in the code but I essentially edited the JS code so that the small/green category for clusters is any cluster with less than or equal to the total number of rows using glue. Ie there functionally cannot be a larger category.

dgkeyes commented 3 years ago

Super! I think this looks good. I just shared with the client. I'll close this issue assuming they're fine with it. If not, I'll let you know. Thanks!