search

rfortherestofus / omni

RMarkdown template, ggplot2 theme, and table function for OMNI Institute
https://rfortherestofus.github.io/omni/
Other
21 stars 4 forks source link

Create ggplot gallery #34

Closed dgkeyes closed 10 months ago

dgkeyes commented 11 months ago

This will probably be in a separate repo (in which case we'll move this issue). Oskar to send latest data viz guidelines and then we'll get started.

R-35

OskaratOmni commented 11 months ago

@dgkeyes , I finally started reviewing the draft ggplot gallery. Unfortunately it is not as far along as I'd hoped. It needs a lot of work and even the plots that are there aren't quite consistent with our own guidelines. I'll see what I can do. I'm not sure if I should just turn it over to you in a ... less-complete-than-we'd-hoped state or try to work on it more this week. More soon. This is just an update.

dgkeyes commented 11 months ago

I do think having you give it to us once it's ready is the best approach.

dgkeyes commented 11 months ago

Ok, I've reviewed all of the docs. @tvroylandt I recorded a video to show you what I'm thinking with this. Do you want to work on creating a draft of a "Data Visualization Principles" vignette based on what I show in the video?

dgkeyes commented 11 months ago

Also, please ignore my comment about adding additional color shades. I looked at the code and you've already done that.

OskaratOmni commented 10 months ago

Hey @dgkeyes and @tvroylandt , it turns out that putting together a proper draft of this is really a lot of work. What I propose is that you review the first few sections, up through 'bar graphs'. You will see that I put a note in brackets in the rmd file saying something like, 'Hey David and Thomas, only review up to this point.' I will explain more in a video shortly.

I added you both as collaborators to this repo: https://github.com/OMNI-Institute-QuantBPT/OMNI-ggplot-gallery

Thomas, you'd asked that I use pull requests to request edits to documents like this, but I'm afraid I need to learn a little bit more about how to do that. Because I am sharing with you the current and main branch, there aren't any changes to compare or request a review of. Does it work okay if you create a branch for your comments and then a pull request to me when you are done? I am happy to adjust the workflow to whatever is best. Please be patient as I learn :-)

OskaratOmni commented 10 months ago

@dgkeyes and @tvroylandt the document for you to review is called: OMNI_ggplot_gallery_main_forDT.rmd where DT ~ David and Thomas.

And again just up until the note after the stacked bar graph. Maybe take a look and let's use those first few graphs to think about our approach - how I can most effectively get content to the two of you, and what we want each section to look like, etc.

dgkeyes commented 10 months ago

Sounds good, thanks!

tvroylandt commented 10 months ago

Thanks. I created a PR by duplicating the files and added comments here : https://github.com/OMNI-Institute-QuantBPT/OMNI-ggplot-gallery/pull/1/files#diff-5158ac4e46b311a0016b820b5575fc19907cba7c7f6d6738453eee920491e797

tvroylandt commented 10 months ago

Don't worry about the mess, this is a great work !

OskaratOmni commented 10 months ago

Very kind of you @tvroylandt ! It was so hard to get it even to this point. :-P

Hey I had this idea: one of the first sections of the document gives an overview of some of our guidelines for graphics. One thing you could do is address how to do some of those things using the OMNI package. This could include things like simply how to show the OMNI color palette with omni::omni_colors() I noticed that OMNI grey is missing from omni_colors - #C2C2C1 for de-emphasized data.

Probably the omni_theme could be updated for things like automatically excluding gridlines?

OskaratOmni commented 10 months ago

Also, don't feel any obligation to preserve any of the ggplot code that is there. We grabbed this code randomly from several projects scattered across the last several years at OMNI. There is nothing special about it, per se. It is only a suggestion for how to achieve the output in some cases.

@tvroylandt , I'm not sure if you are aware of this yet, but the majority of data viz at OMNI is done in excel. Typically, one of us on the quantitative team makes some tables and then hands the tables off to a quite junior staff person on the data viz team who makes the visuals in excel, which are then copy-pasted into word or powerpoint. Obviously, there is great room for improved efficiency with that workflow and I'm really hoping that this ggplot gallery can help.

tvroylandt commented 10 months ago

@OskaratOmni, in the PR, I've started to create a custom guide from your excellent start. For that I use Quarto listings so that the first page could be general guidances and the rest could be a real gallery.

This will also help people to find what's best for them without to be feared by a big guide at once. This is obviously a very work in progress and I will continue to make the gallery one plot after another (as an example, pie chart, donut chart, slopegraph and diverging bar chart are ok). I'll let you know when the PR is ready (I also plan to include tips and tricks and how to in this gallery since we can filter using the categories).

You can render the WIP website by clicking on "Render website" in your "Build" panel in RStudio.