rfortherestofus / omni

RMarkdown template, ggplot2 theme, and table function for OMNI Institute
https://rfortherestofus.github.io/omni/
Other
21 stars 4 forks source link

ggplot gallery: single bar #74

Open OskaratOmni opened 8 months ago

OskaratOmni commented 8 months ago

Reviewer comments:

I think maybe we need two different examples of the single bar: one where it’s used as a thermometer, and one where it’s showing all the components that add up to 100% (like a rectangle-shaped pie chart) like this: image

the example right now is kind of being both with how the labels are done.
to make the current example more like a thermometer, I think we should make the navy blue a light grey and remove the navy label. then label the top left corner “0%” in black or grey, top right corner “100%”. Move the light blue 28% label to centered over where 28% is on the bar (rather than at 0 as it currently is). yellow line can stay as is (maybe will need a different color once switching to grey though).

to make the current example more like a single horizontal stacked bar, I’d remove the yellow line, maybe add another group or two for example sake, move the labels inside the bar if possible, and label the colors with “group A” “group B” etc. (just a note that I’ve seen the single horizontal stacked bar work nicely in cases where the groups sum to 100%, but there are 4+ groups and a pie chart looks messy-- the horizontal format that stretches across the page more easily shows many groups)

dgkeyes commented 8 months ago

Ok, I've done my best to update this.

image

and

image

You can see it live: https://stupendous-biscuit-9f1c75.netlify.app/ggplot/graph_single_bar_chart.html

This is getting into a situation where it's a bit challenging for me to know exactly what you want because I am several steps removed from the work you're doing. Just to put it on your radar, I think we should talk on Friday about getting you and your team to take over ownership of this guide because I think we're reaching the point where having us work on it has diminishing returns.

OskaratOmni commented 8 months ago

Hey David, just remembering this comment. Yeah i would like to get it in our space and figure out how to do such edits.

If there is a new graph or an edit that we find too challenging to make we can always bring you back in.

dgkeyes commented 8 months ago

Let's talk about this on Friday. I definitely think it would be ideal to have your team working on this as well!

OskaratOmni commented 8 months ago

sounds good yeah we have one more round of comments from someone more senior on the data viz team. then its a real draft. i haven't looked at them very closely. It may be that I could implement them - not sure