search

rfortherestofus / omni

RMarkdown template, ggplot2 theme, and table function for OMNI Institute
https://rfortherestofus.github.io/omni/
Other
21 stars 5 forks source link

New Reporting Template #82

Open OskaratOmni opened 7 months ago

OskaratOmni commented 7 months ago

Hey @dgkeyes and @tvroylandt
(David sorry for the double posting with email too)

We have a new template that incorporates some updates to OMNI style.

I'm hoping that we can model report templates in pdf, html, and word for the OMNI R package after this general style template.

Let me know what you think.

thanks! Report Template 2024-specs.pdf

dgkeyes commented 6 months ago

@OskaratOmni just chiming in here to say that Thomas and I talked. He should be able to do the PDF template in the next couple weeks. We can then work on the other formats. We'll comment here with updates/questions.

OskaratOmni commented 6 months ago

Sounds good @dgkeyes , thanks!

tvroylandt commented 6 months ago

@dgkeyes @OskaratOmni I did a first draft on this one in the dedicated branch. Please tell me what you think of it

skeleton.pdf

OskaratOmni commented 6 months ago

Hey @tvroylandt , this looks very good, thank you.

Two questions -

Thanks!

tvroylandt commented 6 months ago
OskaratOmni commented 6 months ago

Hey @tvroylandt how do I view the updated version of this skeleton? I see the commit but am not sure how to view the pdf. Thanks!

tvroylandt commented 6 months ago

Either you can test it on the branch 82-new-reporting-template

skeleton.pdf

Or I put it here. In general we avoid to push pdf, html and so because it's getting big for the Github repo and it throws errors for the R package.

dgkeyes commented 6 months ago

@OskaratOmni if you need help with this, just let us know.

OskaratOmni commented 6 months ago

Hey @tvroylandt , one thing I just noticed on the template is that it looks like the text under the first header isn't all the way left-aligned. Do you see what I mean? The text under first header is slightly indented compared to text under second and third level headers.

Otherwise, I think we are ready to start trying this one out.

What are the next steps for making it useable by our team? Do you push to main branch and we can access it from templates like the others?

Thanks! Oskar

tvroylandt commented 6 months ago

It was the padding of the column. I will merge it and you can use it as it is yes

dgkeyes commented 6 months ago

@OskaratOmni we have merged this so at this point, you can access it just like the other templates. Please have your team try it out and let us know what you see. If/when you want us to make this template in Word and/or HTML formats, please feel free to open a separate issue and we can work on that.

OskaratOmni commented 6 months ago

Sounds good @dgkeyes thanks! I have played with it a little bit and the only minor issue I'm having is that I get warnings like this: 

Warning in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y,  :
  font family not found in Windows font database
Warning in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y,  :
  font family not found in Windows font database
Warning in grid.Call.graphics(C_text, as.graphicsAnnot(x$label), x$x, x$y,  :
  font family not found in Windows font database
Warning in grid.Call.graphics(C_text, as.graphicsAnnot(x$label), x$x, x$y,  :
  font family not found in Windows font database
Warning in grid.Call.graphics(C_text, as.graphicsAnnot(x$label), x$x, x$y,  :
  font family not found in Windows font database

that show up in the pdf when I knit. They are from the first ggplot call. I couldn't identify any fonts that I don't have loaded - the only one I see is Calibri, so I'm puzzled about the warning.

I didn't have time to work on it too hard so I just added a "warning = FALSE" to the knitter chunk options, which works fine. I'm fine with that solution but if you know of something else to check that would cause the font family warning, then please let me know.

dgkeyes commented 5 months ago

Hmm, strange. Can you try this please? https://show.rfor.us/v3tQN0Rb

OskaratOmni commented 5 months ago

Hey @dgkeyes , I was about to start a new issue because i've been having a bunch of data viz problems lately, and most of them were when I was calling theme_omni but lots of just kind of weird behavior. I did a bunch of package updates today and the problems were still there. I couldn't think of anything else so I switched the graphics device backend from AGG back to default and most or all of the data viz problems have gone away. Figures that wouldn't even render are now rendering. Could be a mac thing? Anyway, my guess is that that was not the expected resolution so I just wanted you to know. best Oskar

dgkeyes commented 5 months ago

Hmm, that's strange. Might be worth the two of us getting on a call to go over this and the issues you're seeing in #85. Do you want to schedule something?

OskaratOmni commented 4 months ago

@dgkeyes, scheduled! I did a little googling today and this is the closest thing i found, re; issue 85: https://github.com/rstudio/rmarkdown/issues/2180

I tried reverting to an older version of htmltools, which is of course pretty easy to do. But when I tried knitting with that older version installed it immediately required me to update to the current version anyway. So that wasn't super productive, lol.