rfortherestofus / pagedreport

Templates for {pagedown}
https://pagedreport.rfortherestofus.com
Other
119 stars 19 forks source link

Add Github Actions #15

Closed tvroylandt closed 3 years ago

tvroylandt commented 3 years ago

Add :

tvroylandt commented 3 years ago

@dgkeyes I will add them once we made the repo public, so wednesday

dgkeyes commented 3 years ago

I was going to set up the docs to live somewhere publicly. I thought I might set up Netlify so that a) any changes propagate quicker (GH pages is slow to update), and b) we could put the docs on a subdomain of the RRU site (which should help in making the connection to paid pagedown work in the future). I was thinking to put them at pagedreport.rfortherestofus.com. Does that work for you? If so, why don't we just make the repo public now so that we can make sure everything works?

Also, I realized on Friday that Monday is a holiday in the US (Martin Luther King Jr Day). Let's release it on Tuesday if that's ok with you. I'm working this morning on setting up the following content to promote it:

tvroylandt commented 3 years ago

I'm ok with everything. I will work tomorrow night on this.

dgkeyes commented 3 years ago

Great! Feel free to make the repo public whenever.

tvroylandt commented 3 years ago

I enabled Github Actions for both check and pkgdown.

I just set up the default Actions from usethis. Could you set up a Netlify token and site id in the secret linked to the slot in your website ? You can use the step by step guide I wrote for that here : https://www.tillac-data.com/2020-search-your-tweets-with-an-automatic-pipeline/

dgkeyes commented 3 years ago

Ok, I added those secrets. Let me know if it works.

dgkeyes commented 3 years ago

Actually, I just tried it. The GH action seems to be working, but I'm not sure if it then pushes to Netlify after updating the pkgdown site.

dgkeyes commented 3 years ago

I assume you need to changes some things in the GH action to make it work. Just let me know if you need me to do anything else.

tvroylandt commented 3 years ago

Thanks. Normally I should have to change something in the GHA as in https://github.com/tillac/morphea/blob/master/.github/workflows/collect_tw_table.yaml But everything seems fine and https://pagedreport.rfortherestofus.com/ works. So it will not touch anything for the moment.

dgkeyes commented 3 years ago

It actually stopped working for me. Any idea what's going on?

image

tvroylandt commented 3 years ago

I removed the docs folder and push to Netlify. Otherwise we would have to re-do it manually each time.

Is the netlify part setup on the pkgdown branch and the auto mode disabled (so that Github can push to Netlify)

tvroylandt commented 3 years ago

It's also strange because in the logs of the Actions it's written that it was successful to the right URL

dgkeyes commented 3 years ago

Hmm, I think I probably messed this up. I just manually deployed an earlier commit so it would work for now. I wanted to have it up because I sent an email out to my list this morning. Can we jump on Zoom at 7:30am my time (in 45 minutes) to fix it? I'd do now but everyone is still asleep in my house and I don't want to wake them up.

tvroylandt commented 3 years ago

Yes

dgkeyes commented 3 years ago

The other option is if you want to set up a new netlify site ( this is probably what we should have done in the first place). If you get it all set up correctly and tell me the domain I can then point the DNS to the new site.

tvroylandt commented 3 years ago

Ok I will try it.

tvroylandt commented 3 years ago

Web site : https://nervous-bardeen-960bd8.netlify.app/

dgkeyes commented 3 years ago

Ok, just added the DNS. It usually takes a few minutes to propagate. I'll let you know when it's working.

tvroylandt commented 3 years ago

Do I have anything to do on my side ?

dgkeyes commented 3 years ago

No, I don't think so. I just deleted my Netlify site thinking maybe that had messed it up. Now it just shows the message:

Not found - Request ID: 33f3654f-caa2-492c-a1f0-079c5b1dddb7-1100415

Hopefully the DNS propagation will start working soon!

dgkeyes commented 3 years ago

Oh wait, I think you do need to do something. Go to domain settings, then add the domain alias pagedreport.rfortherestofus.com.

tvroylandt commented 3 years ago

And it works ! !!

tvroylandt commented 3 years ago

https://pagedreport.rfortherestofus.com/

dgkeyes commented 3 years ago

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

dgkeyes commented 3 years ago

Awesome! I'll tweet this out now.