search

rfortherestofus / pagedreport

Templates for {pagedown}
https://pagedreport.rfortherestofus.com
Other
119 stars 19 forks source link

Argument names #18

Closed dgkeyes closed 3 years ago

dgkeyes commented 3 years ago

In going through the vignette, I think we should change some argument names to make things clearer:

I assume common-font is for paragraph text, etc, correct? If so, I think we should call it main-font

Assuming top-font is for headers, why don't we call it header-font?

I'm unclear on the img argument for paged_windmill. How is this different from the front_img?

tvroylandt commented 3 years ago

This one should be dealt with https://github.com/rfortherestofus/pagedreport/commit/6874ac338e962087a9b751dfc12e2372c54d015a and https://github.com/rfortherestofus/pagedreport/commit/4ee4e4c300acb8a7dd8b8d8bed73891eeedf6b94