search

rfquack / RFQuack

RFQuack: the versatile RF-analysis tool that quacks!
https://rfquack.org
GNU General Public License v2.0
209 stars 29 forks source link

Cc1101 fixups #28

Closed akito45 closed 1 year ago

akito45 commented 1 year ago

fixin up missing CC1101 code and changing the protobuf file, so it works with the current RFQuack-cli master branch

note promiscuous mode needs GPIO02 connection.

phretor commented 1 year ago

@akito45 sorry - I made lots of code changes. Do you mind rebasing and sending again?

akito45 commented 1 year ago

@phretor NP, will merge, retest and resubmit.

phretor commented 1 year ago

@akito45 I'm going to close this. I've looked at the commits and I'm not 100% sure about the way you suggest to implement promiscuous mode in CC1101. Also, while displaying logging messages on the CLI is useful, it should be optional, with some configurable filtering on the CLI side.

I've cherry picked a few lines in your implementation of the setPromiscuous and mentioned in your nickname in the commit message.

Happy to review other contributions you may have in the future :-)

Thanks!