rfquack / RFQuack

RFQuack: the versatile RF-analysis tool that quacks!
https://rfquack.org
GNU General Public License v2.0
209 stars 29 forks source link

ECRFv2: Building bug with ECRF set #32

Closed AkaBkn closed 1 year ago

AkaBkn commented 1 year ago

Describe the bug

lib/RadioLib/src/Module.h:49 Module(RADIOLIB_PIN_TYPE cs, RADIOLIB_PIN_TYPE irq, RADIOLIB_PIN_TYPE rst, RADIOLIB_PIN_TYPE gpio, SPIClass& spi, SPISettings spiSettings = RADIOLIB_DEFAULT_SPI_SETTINGS);

docker/project/src/main.cpp.j2

RadioA radioA = new Module(
  {{ RADIOA_CS }},
  {{ RADIOA_IRQ|default('RADIOLIB_NC') }},
  {{ RADIOA_RST|default('RADIOLIB_NC') }}

{% if ECRF is defined %}
  , SPIH, spiSettings
{% endif %}

main.cpp.j2 misses the gpio argument

To Reproduce

having build.env:

BOARD=ESP32
ECRF=true

RADIOA=CC1101
RADIOA_CS=5
RADIOA_IRQ=2
RADIOA_GP=4

RADIOB=CC1101
RADIOB_CS=27
RADIOB_IRQ=25
RADIOB_GP=26

RADIOC=nRF24
RADIOC_CS=15
RADIOC_CE=33
RADIOC_IRQ=7

make clean build

Expected behavior

compiles fine

phretor commented 1 year ago

Please check the documentation for the allowed variables. _CE or _GP don't mean much to RFQuack.

phretor commented 1 year ago

@AkaBkn please check - it compiles on my side.

AkaBkn commented 1 year ago

@phretor looks good, thx :) btw. would be cool to have an example build.env for ECRFv2 with nRF24 too

phretor commented 1 year ago

I'll test it when I'll receive my ECRFv2

joelsernamoreno commented 1 year ago

Mm... Error: Unknown development platform 'espressif32'??

phretor commented 1 year ago

Mm... Error: Unknown development platform 'espressif32'??

Have you tried to change the platform value into platformio.ini ?

joelsernamoreno commented 1 year ago

Fix: platformio upgrade --dev

temskiy commented 1 year ago

I add PR with tested build.env for ECRFv2

phretor commented 1 year ago

Awesome. Thanks @temskiy!