search

rfrancis / asdf-nim

nim plugin for the asdf version manager
Apache License 2.0
7 stars 4 forks source link

Add nim tools install step #4

Closed paradox460 closed 5 years ago

paradox460 commented 5 years ago

Add a step to install that calls koch tools, installing the nimgrep, nimsuggest, and nimpretty tools that come bundled with vim.

Some editor plugins rely on nimsuggest being present for their autocomplete, and nimpretty for their code cleanup.

rfrancis commented 5 years ago

Looks reasonable. Not sure whether that was available back when I wrote this, or whether I just didn't know or care, or what. :-)

On which note, I don't really use nim much these days; if you wanted to ask the asdf folks to direct to your fork instead of here I'd add my support for it, so there'd be an active maintainer. What do you think?

rfrancis commented 5 years ago

Let me go a step further and say that I notice it's failing the test builds and I don't have time to do anything about it, so if you're willing to take charge, I will gladly step aside.

paradox460 commented 5 years ago

I only currently use Nim as a toy project, but I'd happily take it on. I'll also look into the test failure, figure out why its happening. I'd hazard a guess that there isn't a test script included, which ASDF likes to have

paradox460 commented 4 years ago

Hey @rfrancis, i know its been a year, but my interest in Nim is picking up again and I may be able to help you with this project again.

How would you feel about just moving this to be a wrapper around choosenim. I know this isn't the most asdf-ish approach, but it would solve most of the issues. Erlang's installer does something similar, by using kerl to handle its install.

rfrancis commented 4 years ago

My opinion is that whatever works best is right. Since choosenim is what the nim site suggests, I don't see any reason not to take this approach for as long as it works.

On Fri, Jan 10, 2020 at 11:05 PM Jeff S notifications@github.com wrote:

Hey @rfrancis https://github.com/rfrancis, i know its been a year, but my interest in Nim is picking up again and I may be able to help you with this project again.

How would you feel about just moving this to be a wrapper around choosenim. I know this isn't the most asdf-ish approach, but it would solve most of the issues. Erlang's installer does something similar, by using kerl to handle its install.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rfrancis/asdf-nim/pull/4?email_source=notifications&email_token=AAGZ2SJB3WEDHOEINKTJZALQ5FHRVA5CNFSM4GMYEXI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVZQJY#issuecomment-573282343, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGZ2SNRNT26CIZDJ3JG4A3Q5FHRVANCNFSM4GMYEXIQ .