Fix: install from release tarball

rfrancis / asdf-nim

nim plugin for the asdf version manager

Apache License 2.0

7 stars 4 forks source link

Fix: install from release tarball #7

Closed OldhamMade closed 5 years ago

OldhamMade commented 5 years ago

This PR updates the process of installing named versions, by downloading and building from a release tarball (as recommended by the Nim community).

Commit Details

fix to download and build from a release tarball
add warning about downloading directly from github

rfrancis commented 5 years ago

This didn't work for me as is; it failed with:

gzip: stdin: not in gzip format
tar: Child died with signal 13

Changing it to tar -xJ instead of -xv worked, but I have some concern that inconsistency in tar versions may be an issue here. (OSX comes to mind, for one thing.)

It's also arguable that if the tarball method fails it should fall back to the git clone method.

Anyway, as is I'm not going to merge it yet since it breaks the plugin for me. :-) (Fedora 29, for the record.)

OldhamMade commented 5 years ago

It's also arguable that if the tarball method fails it should fall back to the git clone method.

Problem with this approach is that this approach isn't working for me on macOS with older versions of Nim.

However, I'll withdraw and update.