search

rfresh2 / XaeroPlus

Xaero WorldMap / Minimap Extra Features
MIT License
86 stars 25 forks source link

Create es_ar translation #120

Closed thaqalayn closed 4 months ago

thaqalayn commented 5 months ago

Not exactly sure if I need to make a PR for each branch so for now simply making one PR.

thaqalayn commented 5 months ago

Just built and tried it out, I noticed there are a lot of missing objects within the translation .json template (copied es_ar from en_us), not sure if these are able to be added so we can have a more complete translation of the mod. Some examples:

image

image

rfresh2 commented 5 months ago

Thanks!

Not exactly sure if I need to make a PR for each branch so for now simply making one PR.

No, this is fine. I'll merge it into the other branches when i publish a new release

I noticed there are a lot of missing objects within the translation

Yeah all those are not strings from XaeroPlus. Those are from Xaero's WorldMap/Minimap mods. I don't have any control over what his translations are or aren't in those. There's a repo for Minimap: https://github.com/thexaero/xaero-minimap-translations but I don't think there's a repo for WorldMap.

thaqalayn commented 5 months ago

Understood, well then I guess this is the best that can be done then.