search

rfresh2 / XaeroPlus

Xaero WorldMap / Minimap Extra Features
MIT License
97 stars 27 forks source link

Bumped versions: Gradle wrapper, XaerosWorldMap, XaerosMinimap, owo-lib, Fabric loader etc #59

Closed lospejos closed 11 months ago

lospejos commented 12 months ago

Bumped versions: Gradle wrapper to 8.3, XaerosWorldMap 1.34.1_Fabric_1.20, XaerosMinimap 23.8.0_Fabric_1.20, owo-lib 0.11.2+1.20, Fabric loader 0.14.22, Fabric 0.88.1+1.20.1

rfresh2 commented 12 months ago

I'm currently out of town with no pc, so I can't test for 2-3 days.

Due to how many overwrite mixins I use, just bumping xaero versions is most often not enough. I decompile every xaero update and compare to the previous version to make sure I actually apply his changes.

If you want this pr accepted I'd ask you to do the same, I have a private repo with the decompiled source I can add you to.

It may be much more work required on your part though. So it's fine if u just wanna wait until I'm back and I'll handle all that.

lospejos commented 12 months ago

I'm currently out of town with no pc, so I can't test for 2-3 days.

Due to how many overwrite mixins I use, just bumping xaero versions is most often not enough. I decompile every xaero update and compare to the previous version to make sure I actually apply his changes.

If you want this pr accepted I'd ask you to do the same, I have a private repo with the decompiled source I can add you to.

It may be much more work required on your part though. So it's fine if u just wanna wait until I'm back and I'll handle all that.

Thanks for your reply. I recompiled mod with changes made by me in this PR, and faced no crashes nor errors. IDK maybe this mod was not working thus no was no errors.