rfresh2 / XaeroPlus

Xaero WorldMap / Minimap Extra Features
MIT License
102 stars 27 forks source link

XaeroPlust crash on Minecraft 1.20.4 with Waystones installed #99

Closed Devil64-Dev closed 8 months ago

Devil64-Dev commented 8 months ago

Mod runtime information

Other

Minecraft crash on launch with both XaeroPlus and Waystones installed, in the logs the following error is reported as the main cause of the crash:

java.lang.RuntimeException: java.lang.NoClassDefFoundError: net/blay09/mods/waystones/api/KnownWaystonesEvent
at xaero.map.WorldMap.tryLoadLater(WorldMap.java:262)
    at xaero.map.core.XaeroWorldMapCore.onMinecraftRunTick(XaeroWorldMapCore.java:169)
    at net.minecraft.class_310.handler$dlp000$xaeroworldmap$onRunTickStart(class_310.java:17275)
    at net.minecraft.class_310.method_1523(class_310.java)
    at net.minecraft.class_310.method_1514(class_310.java:888)
    at net.minecraft.client.main.Main.main(Main.java:265)
    at
...

Caused by: java.lang.ClassNotFoundException: net.blay09.mods.waystones.api.KnownWaystonesEvent

After browsing the Waystones source code I found that the commit 4c212741d9f3079d9dec660eec66baa4bc070082 causes the crash because the class KnownWaystonesEvent is removed from the code, so in new Waystones updates is not available and the XaeroPlus mod crashes when a new version of Waystones is installed.

NOTE: After some testing I managed to resolve the issue by updating some parts of the code, I was thinking on doing a PR but not sure...

rfresh2 commented 8 months ago

Thanks for reporting, seems there was a waystones update a week or 2 ago that changed some internals when it was updated to 1.20.4.

i'll release an update shortly

rfresh2 commented 8 months ago

Released https://github.com/rfresh2/XaeroPlus/releases/tag/Fabric-1.20.4-8