rfvgyhn / min-ed-launcher

Minimal Elite Dangerous Launcher
MIT License
251 stars 9 forks source link

the last update tries to install the vanilla legacy despite it's already being present #132

Closed anzial closed 2 months ago

anzial commented 2 months ago

Describe the bug/error I'm using two PCs to run the same game/commander from frontier launcher. I've used mined launcher on one without any issues for a while and tried to do the same on the 2nd. After I successfully logged into the game in minED, for some reason it keeps trying to install Legacy version of the game on top of the Legacy Horizons that's already there. I actually played vanilla Legacy a couple of weeks (Legacy horizons after that) without any problems using frontier launcher, and yet minED insists it's not there and tries installing it (I stop it from doing so). In the meantime, there's no such problem on my main computer which also has legacy installed (both versions). I obviously don't want to waste space or bandwidth re-downloading the part of the game which is already installed but minED for some reason doesn't see it. Is there a way to stop it from trying to download/install vanilla legacy? looked through documentation and besides disabling autoupdate entirely I don't see how to do it.

Debug log 2024-06-09 21:03:25.171 +05:00 [DBG] Reading settings from 'C:\Users\xxxx\AppData\Local\min-ed-launcher\settings.json' 2024-06-09 21:03:25.453 +05:00 [DBG] Settings: { Platform = Frontier { Profile = "xxxxx" Credentials = Some { Username = "xxxxxx" Password = "xxxxx" } AuthToken = Some "xxxx" } DisplayMode = Pancake AutoRun = true AutoQuit = true WatchForCrashes = false ProductWhitelist = seq ["edo"] ForceLocal = false CompatTool = None CbLauncherDir = "I:\games\Elite Dangerous\" PreferredLanguage = None ApiUri = https://api.zaonce.net/ Restart = None AutoUpdate = true CheckForLauncherUpdates = true MaxConcurrentDownloads = 4 ForceUpdate = set [] Processes = [] ShutdownProcesses = [] FilterOverrides = seq [[FORC-FDEV-DO-1000, edo]; [FORC-FDEV-DO-38-IN-40, edh4]] AdditionalProducts = [] DryRun = false ShutdownTimeout = 00:00:10 CacheDir = "G:\test\mined" GameStartDelay = 00:00:00 ShutdownDelay = 00:00:00 } 2024-06-09 21:03:25.552 +05:00 [INF] Elite Runtime Platform: Frontier CobraBay Version: 1.7.6972.1 Products Dir: I:\games\Elite Dangerous\Products 2024-06-09 21:03:25.559 +05:00 [DBG] Getting machine id 2024-06-09 21:03:25.572 +05:00 [INF] Logging in 2024-06-09 21:03:25.572 +05:00 [DBG] Getting remote time 2024-06-09 21:03:26.701 +05:00 [DBG] Authenticating via Frontier 2024-06-09 21:03:26.921 +05:00 [DBG] Successfully authenticated 2024-06-09 21:03:26.921 +05:00 [INF] Logged in via Frontier as: xxxx 2024-06-09 21:03:26.921 +05:00 [DBG] Getting authorized products 2024-06-09 21:03:27.685 +05:00 [DBG] Purchases Response: {"purchases"--snipped 2024-06-09 21:03:27.693 +05:00 [DBG] Authorized Products: Elite Dangerous: Odyssey,Elite Dangerous: Horizons,Legacy Horizons,Legacy Elite Dangerous,Elite Dangerous: Arena,Single Player Combat Training 2024-06-09 21:03:27.693 +05:00 [INF] Checking for updates 2024-06-09 21:03:28.686 +05:00 [DBG] Launcher is latest release 0.10.1 2024-06-09 21:03:28.692 +05:00 [DBG] Unable to find product's version info at 'I:\games\Elite Dangerous\Products\COMBAT_TUTORIAL_DEMO\VersionInfo.txt' 2024-06-09 21:03:30.092 +05:00 [INF] Available Products: Elite Dangerous: Odyssey FORC-FDEV-DO-1000 Up to Date Elite Dangerous: Horizons FORC-FDEV-DO-38-IN-40 Up to Date Legacy Horizons FORC-FDEV-D-1013 Up to Date Legacy Elite Dangerous FORC-FDEV-D-1010 Requires Update Elite Dangerous: Arena FORC-FDEV-D-1012 Up to Date Single Player Combat Training COMBAT_TUTORIAL_DEMO Not Installed 2024-06-09 21:03:30.094 +05:00 [INF] Fetching product manifest(s) 2024-06-09 21:03:31.251 +05:00 [INF] Updating Legacy Elite Dangerous 2024-06-09 21:03:31.350 +05:00 [INF] Determining which files need to be updated 2024-06-09 21:03:31.350 +05:00 [INF] Checking download cache 2024-06-09 21:03:34.597 +05:00 [INF] Checking existing files 2024-06-09 21:03:34.899 +05:00 [DBG] Wrote hash cache to 'G:\test\mined\hashmap.FORC-FDEV-D-1010.txt' 2024-06-09 21:03:34.900 +05:00 [DBG] Wrote hash cache to 'G:\test\mined\Win64_Release_3_8_0_2002022.11.24.289583\hashmap.txt' 2024-06-09 21:03:34.938 +05:00 [INF] Downloading 35702 files (I stop the minED after this)

rfvgyhn commented 2 months ago

Looks similar to #126 except the log isn't showing that VersionInfo.txt is missing. It's possible there's an issue with it checking for directory name vs SKU. If you check I:\games\Elite Dangerous\Products, do you have elite-dangerous-64 or FORC-FDEV-D-1013? If the later, you might try renaming it to elite-dangerous-64.

Otherwise, you'll have to either disable autoUpdate or revert back to v0.9.0 until this can be identified and fixed.

rfvgyhn commented 2 months ago

Another thing to try to narrow down the issue would be to rename VersionInfo.txt to VersionInfo.txt.bak in the Legacy Horizons product directory (rename it back when you are done testing). This will make min-ed-launcher not recognize it as being installed. In that scenario, does it still try to install anything?

Could you also provide the folder names you have in your products directory?

anzial commented 2 months ago

turns out it was a conflict between two installs of legacy. Steam, for some reason, decided to add the "FORC-FDEV-D-1010" folder on top of the existing "elite-dangerous-64" folder. At the time I was adding ody DLC so thought it was related to it but it's clearly was just a glitch. I removed the offending folder and now minED works as intended. It's kinda bizarre for steam to add that folder after so long although, to be fair, I rarely use steam to play ED, mostly just the frontier/minED without it.

rfvgyhn commented 2 months ago

Cool, glad you figured it out.

It's a shame FDev decided that Steam and Epic prefer directory name and Frontier prefers SKU to name the folders. I think that's the main source of issues like this.