rfvgyhn / min-ed-launcher

Minimal Elite Dangerous Launcher
MIT License
252 stars 9 forks source link

run epic through Stream closes out min-ed-launcher #40

Closed ninjaijr closed 2 years ago

ninjaijr commented 2 years ago

So i'm following the steps listed on the read me to try to load into my epic account.

i did follow the step to install ED on epic store until those files were created but when i tried to move them to the same folder as min-ed-launcher i got a replace prompt... so i canceled as they are there already there (via steam?) and didnt want to replace them.

i grabbed the Epic exchange code as stated in the step and added it to this command in steam

konsole -e ./MinEdLauncher %command% /autorun /autoquit /EDO -auth_password= << i copy code here

min-ed-launcher comes up and starts the process and i can briefly see EPIC as the client but the command window closes

heres a piece from the log

2021-10-19 01:06:50.244 -07:00 [DBG] Requesting epic token 2021-10-19 01:06:50.583 -07:00 [DBG] Requesting epic token fail 2021-10-19 01:06:50.592 -07:00 [ERR] Couldn't login: 400: Bad Request

is there a step i might be missing? am i getting the code incorrectly as i see it in the url?

URL = https://accounts.epicgames.com/exchange?exchangeCode=3c47c97d7b844c1b9b06fad54714186f&redirectUrl=https%3A%2F%2Fstore-launcher.epicgames.com%2Fsite%2Faccount%3Flang%3Den-US

What im pasting 3c47c97d7b844c1b9b06fad54714186f

i've attached the full log as well

min-ed-launcher.log

rfvgyhn commented 2 years ago

Looks like FDev added the Epic dlls to their Steam depot which means you wouldn't need to download and copy them from the Epic install. The readme should be updated to reflect that.

It also looks like Epic now requires a User-Agent header when requesting an auth token. I'll need to push an update to address that.

ninjaijr commented 2 years ago

looking forward to the update :)

ninjaijr commented 2 years ago

i have updated my install and still get the same error... what info do you need from me to further investigate. logs attached min-ed-launcher.log

rfvgyhn commented 2 years ago

I've added some better logging. Can you try the CI build and post the new error message?

ninjaijr commented 2 years ago

the CI build runs and instantly closes. does not generate a log file. i downloaded it twice and removed the file from ED folder where i pasted it to verify it wasnt a system issue

rfvgyhn commented 2 years ago

If you just run it from a terminal manually, does it output anything?

ninjaijr commented 2 years ago
bash: ./MinEdLauncher: Permission denied
[marc@manjaropc Elite Dangerous]$ konsole -e ./MinEdLauncher %command% /autorun /autoquit /EDO -auth_password=414146c7b9fd44d79496781764540921
"Could not find binary: " "/home/marc/Steam"
"Could not find binary: " "/home/marc/Steam"
[marc@manjaropc Elite Dangerous]$ sudo ./MinEdLauncher /autorun /autoquit /EDO -auth_password=414146c7b9fd44d79496781764540921
sudo: ./MinEdLauncher: command not found
[marc@manjaropc Elite Dangerous]$ 
rfvgyhn commented 2 years ago

Does MinEdLauncher have the executable bit set? You might need to add it (chmod u+x MinEdLauncher).

ninjaijr commented 2 years ago

here you go

[marc@manjaropc Elite Dangerous]$ ./MinEdLauncher %command% /autorun /autoquit /EDO -auth_password=82b42dc56ead4a26ba37525492589651
[23:14:46 INF] Elite Dangerous: Minimal Launcher - v0.5.4-ci1361980898
[23:14:46 INF] Elite Runtime
    Platform: Epic
    CobraBay Version: 0.4.6709.0
    Products Dir: /home/marc/Steam NVME/steamapps/common/Elite Dangerous/Products
[23:14:48 ERR] Couldn't get machine id: Unable to find wine directory. Make sure either STEAM_COMPAT_DATA_PATH or WINEPREFIX is set
[marc@manjaropc Elite Dangerous]$ 

i used chmod+x MinEdLauncher to make it executable. that i havent had to do that prior when running it normally

rfvgyhn commented 2 years ago

Cool, so now it at least runs. Can you run it from Steam and see what error crops up next?

ninjaijr commented 2 years ago

new log min-ed-launcher.log

rfvgyhn commented 2 years ago

Sorry the exchange code you supplied was not found. It is possible that it was no longer valid means Epic rejected the exchange code that was supplied. I'm guessing this is a timing issue with using the exchange code before the browser page is redirected to your account page. When the browser opens, do you click the stop button before it redirects or do you just copy the code before it redirects?

ninjaijr commented 2 years ago

copy before it redirects then close the tab... i tried hitting stop but them it would still redirect... loads so fast

ninjaijr commented 2 years ago

i tried it again and was able to time it correctly and get past code error.

new log min-ed-launcher.log

ninjaijr commented 2 years ago

on a side note... i found this when looking for fixes for epic and ED

https://www.youtube.com/watch?v=mZXVb26d7Ao

he edits the epic manifest to run it through steam ... with a few extra steps as well :)

hope that helps

rfvgyhn commented 2 years ago

That's an intermittent issue with the FDev API. I don't know if it's on my end or on their end, but I've seen users receive HTML instead of JSON when trying to auth at seemingly random times. Do you see this issue every time you try or does it go away if you try again?

Thanks for the video. I attempted to go down that path early on but found out that file gets overwritten when verifying game files (and perhaps updates too).

ninjaijr commented 2 years ago

Apologies for the lateness .... i tried it a few times over the next 2 days after we last spoke and it still gave the html error but today it finally accepted the Epic code. one thing i noticed was that on my epic account i only have horizons while on my Steam account i have odyssey. this brings up another question in regards to multi account... is there any way to pass the Game version via shortcut... i tried passing /EDO and EDH but when i ran the launcher it gave the following error then closerd

2021-10-24 18:56:20.717 -07:00 [ERR] No selected project

i wanted to create 1 shortcut that ran appended with /EDO and a second that ran /EDH -auth_password=code

i did add the //

rfvgyhn commented 2 years ago

It looks like I only tested shortcuts on Windows. On Linux, I couldn't get the shortcut that steam creates to work with additional arguments. You can edit the .desktop file though and set Exec to steam -applaunch 359320 /edh -auth_password=code. I'll need to fix the readme.

It also looks like the arguments are prepended on linux, so you'll need to remove /edh or /edo from your launch options within steam.

If that doesn't work for you, can you post the full log for that attempt (starting from [INF] Elite Dangerous: Minimal Launcher - v{version}?

ninjaijr commented 2 years ago

got it to work with the above... thanks... and just to clarify for anyone who might be trying to do the same as i am here is the final set up

Steam launch options konsole -e ./MinEdLauncher %command% /autorun /autoquit

1st shortcut (for odyssey/Steam) steam -applaunch 359320 /edo

2nd shortcut (Horizons/Epic) steam -applaunch 359320 /edh -auth_password=(code)