extend the unitcode limit on RFY subtype

rfxcom / node-rfxcom

Node.js client for talking to an RFXtrx433 device

MIT License

61 stars 45 forks source link

extend the unitcode limit on RFY subtype #86

Closed jgaret closed 5 years ago

jgaret commented 5 years ago

The rfy subtype accepts unitcodes at least up to 0x0b (tested and working on my setup), I think it should be up to 0x0f.

maxwellhadley commented 5 years ago

I have checked with RFXCOM, and it appears that operation with unit codes higher than 4, especially with codes 5 & 6, may not always work reliably. It is recommended not to use unit numbers higher than 4. Since node-rfxcom isn't restricted to a single 'remote' address, there is no real need to use higher unit codes anyway.

Therefore I won't be accepting this PR into the repo