search

rg2 / xreg

Library and executables for modeling and registration applications in medical image analysis. Particular emphasis on intraoperative fluoroscopic (X-ray) navigation via 2D/3D registration.
MIT License
91 stars 18 forks source link

Log density calculation is incorrect in NormalDist2DIndep #18

Closed rg2 closed 1 year ago

rg2 commented 2 years ago

The implementation performs ((x-mu_x)/sigma_x)^2 * ((y-mu_y)/sigma_y)^2 instead of adding: ((x-mu_x)/sigma_x)^2 + ((y-mu_y)/sigma_y)^2

https://github.com/rg2/xreg/blob/d32dbe74c9072cc6ac973055797abec14b0c6389/lib/basic_math/xregNormDist.cpp#L108-L110

rg2 commented 1 year ago

Fixed in #19 , commit b57e5e36036890c0e25cd3489c8d27f7c5bc2b41.