rg3l3dr / omnibuilds-app

A Vue.js SPA for OmniBuilds
https://www.omnibuilds.com
0 stars 0 forks source link

Success Message does not close correctly when Uploading Files #11

Closed rg3l3dr closed 6 years ago

rg3l3dr commented 7 years ago

Description

I'm using a dismissible block message to notify the user after files have been uploaded in the design view, under the files tab.

https://semantic-ui.com/collections/message.html#dismissable-block

While it works generally, there are some corner cases that are showing strange behavior.

Possible Workflows

  1. User Uploads a new file/s and waits for the message
    1. User dismisses the message
    2. User does not dismiss the message
  2. User Uploads another version of an existing file
    1. File has changed -> versions the file and gives a success message
    2. File has not changed -> does not version the file and and gives a success message
  3. User uploads another version of an existing file
    1. User clicks on past versions link before the file upload has completed

Resolution

Generally speaking, the dismissible block is not resetting after it has been closed, and it should be automatically reset anytime a new file is uploaded.

I would suggest abstracting the logic for resetting a message into a function and calling that every time a user clicks the upload button (before uploading files)

https://github.com/jwagstaff/app/blob/master/src/components/designs/files.vue#L664-L679