search

rgalanakis / minimaestro

0 stars 0 forks source link

When highlights are enabled, buttons are still active #24

Closed rgalanakis closed 10 years ago

rgalanakis commented 10 years ago
  1. Click 'woodwinds' highlight button
  2. Click over the 'play' button
  3. The dimmer is turned off (good), but the game goes to the next song (bad). All buttons should be disabled.
bmumm commented 10 years ago

fix should be on master will have to test on ipad.

rgalanakis commented 10 years ago

Still a small problem:

  1. Click the 'woodwinds' highlight button.
  2. Click over the 'play' button.
  3. The dimmer is turned off (good), and the song does not advance (good), but the button plays its mouse-over jelly-shake animation (bad).
bmumm commented 10 years ago

I actually like the animation and hover is a none issue anyway for ios.

rgalanakis commented 10 years ago

OK let's see how it looks on touch. On Jun 12, 2014 12:23 PM, "bmumm" notifications@github.com wrote:

I actually like the animation and hover is a none issue anyway for ios.

— Reply to this email directly or view it on GitHub https://github.com/rgalanakis/minimaestro/issues/24#issuecomment-45921695 .

rgalanakis commented 10 years ago

The original bug is present on iOS.

rgalanakis commented 10 years ago

Fixed.