search

rgamba / evtwebsocket

Dead easy event based websockets
52 stars 16 forks source link

Added subprotocol specification and Conn as a parameter in events #3

Closed brettjbush closed 7 years ago

brettjbush commented 7 years ago

Hi rgamba,

I really like your event driven websocket implementation for Go! Best and easiest to use library I've found for the language.

I have a few things I would like to add to your library:

  1. The ability to specify a subprotocol on Dial
  2. Pass the main Conn object as an argument to events in order to allow OnConnected and OnMessage to run Send(msg)

If you would like to me to make any adjustments so as to fit in more with your implementation, I would be happy to make them. Thanks for a great library!

Brett

brettjbush commented 7 years ago

Thanks for feedback,

Sure thing, I'll make the changes you've described.